xudong963 commented on code in PR #6630:
URL: https://github.com/apache/arrow-rs/pull/6630#discussion_r1970848784
##########
parquet/src/errors.rs:
##########
@@ -47,6 +47,8 @@ pub enum ParquetError {
IndexOutOfBound(usize, usize),
/// An external error variant
External(Box<dyn Error + Send + Sync>),
+ /// Returned when a function needs more data to complete properly.
+ NeedMoreData(usize),
Review Comment:
@alamb If add the `#[non_exhaustive]` to `ParquetError`, when the downstream
matches `ParquetError`, we have to add the `_`,
https://doc.rust-lang.org/reference/attributes/type_system.html#r-attributes.type-system.non_exhaustive.match
such as
```
match parquet_error {
... => {},
_ => {} // We have to add the `_`,
https://doc.rust-lang.org/reference/attributes/type_system.html#r-attributes.type-system.non_exhaustive.match
}
```
I'm worried that if we add a new error type into `ParquetError`, the
downstream will be unsensible due to `_`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
