ianmcook commented on a change in pull request #9798:
URL: https://github.com/apache/arrow/pull/9798#discussion_r602579544
##########
File path: r/tests/testthat/test-dplyr.R
##########
@@ -369,3 +384,46 @@ test_that("tail", {
group_by(int)
)
})
+
+test_that("relocate", {
+ df <- tibble(a = 1, b = 1, c = 1, d = "a", e = "a", f = "a")
+ expect_dplyr_equal(
+ input %>% relocate(f) %>% collect(),
+ df,
+ )
+ expect_dplyr_equal(
+ input %>% relocate(a, .after = c) %>% collect(),
+ df,
+ )
+ expect_dplyr_equal(
+ input %>% relocate(f, .before = b) %>% collect(),
+ df,
+ )
+ expect_dplyr_equal(
+ input %>% relocate(a, .after = last_col()) %>% collect(),
+ df,
+ )
+ expect_dplyr_equal(
+ input %>% relocate(ff = f) %>% collect(),
+ df,
+ )
+})
+
+test_that("relocate with selection helpers", {
+ expect_dplyr_equal(
+ input %>% relocate(any_of(c("a", "e", "i", "o", "u"))) %>% collect(),
+ df
+ )
+ expect_error(
+ df %>% Table$create() %>% relocate(where(is.character)),
Review comment:
Huh, the docs says they are "questioning" but not yet deprecated
https://github.com/r-lib/tidyselect/blob/69fdc96fd9f47a7ae5563c33d356ae67dc0799e8/R/lifecycle-deprecated.R#L5-L7
Either way, we should try to replace them with `eval_select()`. I made an
attempt to do that as part of this PR but it got very complicated and I backed
out. I'll open a Jira for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
