pitrou commented on code in PR #45612:
URL: https://github.com/apache/arrow/pull/45612#discussion_r1973159357
##########
cpp/src/arrow/acero/swiss_join_internal.h:
##########
@@ -604,6 +609,16 @@ class SwissTableForJoinBuild {
MemoryPool* pool_;
int64_t hardware_flags_;
+ // One per batch.
+ //
+ // Informations like hashes and partitions of each batch.
+ //
+ struct BatchState {
+ std::vector<uint32_t> hashes;
+ std::vector<uint16_t> prtn_ranges;
+ std::vector<uint16_t> prtn_row_ids;
Review Comment:
It might be worth adding comments as to that (the cardinality of each
BatchState member).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
