pitrou commented on code in PR #45367:
URL: https://github.com/apache/arrow/pull/45367#discussion_r1973285903
##########
cpp/src/parquet/column_writer.cc:
##########
@@ -1033,10 +1033,15 @@ void ColumnWriterImpl::BuildDataPageV2(int64_t
definition_levels_rle_size,
// Compress the values if needed. Repetition and definition levels are
uncompressed in
// V2.
std::shared_ptr<Buffer> compressed_values;
- if (pager_->has_compressor()) {
+ bool page_is_compressed = false;
+ if (pager_->has_compressor() && values->size() > 0) {
pager_->Compress(*values, compressor_temp_buffer_.get());
- compressed_values = compressor_temp_buffer_;
- } else {
+ if (compressor_temp_buffer_->size() < values->size()) {
+ compressed_values = compressor_temp_buffer_;
+ page_is_compressed = true;
+ }
+ }
+ if (!page_is_compressed) {
compressed_values = values;
}
Review Comment:
How about making this a bit simpler:
```c++
bool page_is_compressed = false;
if (pager_->has_compressor() && values->size() > 0) {
pager_->Compress(*values, compressor_temp_buffer_.get());
if (compressor_temp_buffer_->size() < values->size()) {
page_is_compressed = true;
}
}
std::shared_ptr<Buffer> compressed_values = (
page_is_compressed ? compressor_temp_buffer_ : values);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
