paleolimbot commented on code in PR #2546: URL: https://github.com/apache/arrow-adbc/pull/2546#discussion_r1976060429
########## c/vendor/nanoarrow/CMakeLists.txt: ########## Review Comment: I think this CMakeLists.txt lives in ADBC...is the suggestion that nanoarrow should include a CMakeLists.txt with the bundled nanoarrow.c/h? It may also be time to just use CMake install or build-time dependency for nanoarrow (since our existing CMakeLists.txt now supports that and is tested against a number of scenarios). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
