aiguofer commented on PR #464: URL: https://github.com/apache/arrow-java/pull/464#issuecomment-2692950902
Ok I tried to fix the existing tests but now I'm worried that the change to not modify the offset for Timestamp vectors w/o TZ info might have an inconsistent behavior with `TimeVector` accessors, `DateVector` accessors, and `getTimestamp` accessor for `VarCharVector`. I also noticed that what we currently do for `TimeStampVector` is already inconsistent with what we do for `TimeVector` and `DateVector` accessors. For the latter, we use `DateTimeUtils.applyCalendarOffset`, which uses `TimeZone.getDefault()` to determine our current timezone. However, for `TimeStampAccessor` we assume `UTC` if not provided. There's a lot of inter-related parts here and breaking changes could be troublesome. I'm going to change behavior so that usage of the "legacy" JDBC date/time objects stays the same and we can simply recommend that users use `getObject(<java.time.* class>)` to get expected behaviors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
