CurtHagenlocher commented on issue #45559:
URL: https://github.com/apache/arrow/issues/45559#issuecomment-2693238338
Have you benchmarked to confirm whether this change makes any performance
difference? It's my understanding -- backed up by an experiment with SharpLab
-- that the C# compiler translates the idiom `static ReadOnlySpan<byte>
Property => new byte[] { ... };` into a reference directly into static data.
(The C# compiler PR in question is https://github.com/dotnet/roslyn/pull/24621.)
The suggested change to `GetBit` feels risky, in that some code might be
dependent on its current behavior to validate the lower bound. It would be
interesting to microbenchmark this too, at least so we have some idea of how
much performance is being given up.
If you haven't used it before, Benchmark.NET is great for this purpose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
