CurtHagenlocher commented on code in PR #2540: URL: https://github.com/apache/arrow-adbc/pull/2540#discussion_r1977770503
########## csharp/src/Drivers/Apache/Hive2/HiveServer2ConnectionFactory.cs: ########## @@ -0,0 +1,38 @@ +/* +* Licensed to the Apache Software Foundation (ASF) under one or more +* contributor license agreements. See the NOTICE file distributed with +* this work for additional information regarding copyright ownership. +* The ASF licenses this file to You under the Apache License, Version 2.0 +* (the "License"); you may not use this file except in compliance with +* the License. You may obtain a copy of the License at +* +* http://www.apache.org/licenses/LICENSE-2.0 +* +* Unless required by applicable law or agreed to in writing, software +* distributed under the License is distributed on an "AS IS" BASIS, +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +* See the License for the specific language governing permissions and +* limitations under the License. +*/ + +using System; +using System.Collections.Generic; + +namespace Apache.Arrow.Adbc.Drivers.Apache.Hive2 +{ + internal class HiveServer2ConnectionFactory + { + public static HiveServer2Connection NewConnection(IReadOnlyDictionary<string, string> properties) + { + bool _ = properties.TryGetValue(HiveServer2Parameters.Type, out string? type); + bool __ = HiveServer2TypeParser.TryParse(type, out HiveServer2Type typeValue); + return typeValue switch + { + HiveServer2Type.Http => new HiveServer2HttpConnection(properties), + HiveServer2Type.Empty => throw new ArgumentException($"Required property '{HiveServer2Parameters.Type}' is missing. Supported types: {HiveServer2TypeParser.SupportedList}", nameof(properties)), + _ => throw new ArgumentOutOfRangeException(nameof(properties), $"Unsupported or unknown value '{type}' given for property '{HiveServer2Parameters.Type}'. Supported types: {HiveServer2TypeParser.SupportedList}"), + }; + } + Review Comment: There's still an extra blank line in the latest iteration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
