zeroshade commented on code in PR #302:
URL: https://github.com/apache/arrow-go/pull/302#discussion_r1979738429
##########
parquet/file/page_reader.go:
##########
@@ -533,7 +533,7 @@ func (p *serializedPageReader) GetDictionaryPage()
(*DictionaryPage, error) {
hdr := format.NewPageHeader()
rd := utils.NewBufferedReader(
io.NewSectionReader(p.r.Outer(),
p.dictOffset-p.baseOffset, p.dataOffset-p.baseOffset),
- p.r.BufferSize())
+ int(parquet.DefaultBufSize))
Review Comment:
This would remove our respecting of the BufferSize property in the reader
properties, we shouldn't be removing the `BufferSize()` method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
