kou commented on code in PR #652: URL: https://github.com/apache/arrow-java/pull/652#discussion_r1981165314
########## flight/flight-sql-jdbc-driver/src/shade/NOTICE.txt: ########## @@ -73,7 +73,7 @@ This product includes gRPC 1.70.0, with the following in its NOTICE: --------------------------------------------------- -This product includes Netty 4.1.117.Final, with the following in its NOTICE: +This product includes Netty 4.1.119.Final, with the following in its NOTICE: Review Comment: I'm not familiar with Java but I thought `flight-sql-jdbc-driver-19.0.0-SNAPSHOT.jar` is a binary artifact not a source archive. (I thought that https://repository.apache.org/content/repositories/staging/org/apache/arrow/flight-sql-jdbc-driver/18.2.0/flight-sql-jdbc-driver-18.2.0-sources.jar is a source archive for flight-sql-jdbc-driver.) We use "This binary artifact contains ..." in other files for binary artifact and we use "This product includes ..." for copied sources. e.g.: https://github.com/apache/arrow-java/blob/cf8b2521ca43c862784b67d32af94861dea1d388/LICENSE.txt#L205 So I thought: * We don't need this for source archive? * We should use "This binary artifact ..."? BTW, I noticed that this isn't used for `-sources.jar`! This is used only for `.jar`, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
