spenczar commented on code in PR #38334:
URL: https://github.com/apache/arrow/pull/38334#discussion_r1982253727
##########
python/pyarrow/tests/test_array.py:
##########
@@ -710,9 +710,9 @@ def test_struct_from_arrays():
assert arr.to_pylist() == []
# Inconsistent fields
- fa2 = pa.field("a", pa.int32())
- with pytest.raises(ValueError, match="int64 vs int32"):
- pa.StructArray.from_arrays([a, b, c], fields=[fa2, fb, fc])
Review Comment:
Right, I am coercing inputs to match the provided types specified by the
user. I don't think it's obvious whether this is right or wrong; there is no
specification here.
We could require types to be identical (no coercion) if the input values are
all Pyarrow Arrays. The implementation will just be a little more complex. Let
me know what you prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
