kou commented on issue #2584: URL: https://github.com/apache/arrow-adbc/issues/2584#issuecomment-2705416176
OK. Let's improve Vala availability detection: https://github.com/apache/arrow-adbc/blob/9a10e6791db6d54b813fde4df3925c354822192e/ci/scripts/glib_build.sh#L41 Something like: ```diff diff --git a/ci/scripts/glib_build.sh b/ci/scripts/glib_build.sh index fdc1276f4..64255d8dd 100755 --- a/ci/scripts/glib_build.sh +++ b/ci/scripts/glib_build.sh @@ -38,7 +38,8 @@ build_subproject() { cmake_prefix_path="${CONDA_PREFIX}:${cmake_prefix_path}" pkg_config_path="${pkg_config_path}:${CONDA_PREFIX}/lib/pkgconfig" fi - if type valac > /dev/null 2>&1; then + if type valac > /dev/null 2>&1 && \ + [[ -n "$(pkg-config --variable=vapidir arrow-glib)" ]]; then enable_vapi=true else enable_vapi=false ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
