lidavidm commented on code in PR #658:
URL: https://github.com/apache/arrow-java/pull/658#discussion_r1984254146
##########
gandiva/src/main/java/org/apache/arrow/gandiva/evaluator/JniLoader.java:
##########
@@ -69,6 +75,9 @@ private static void loadGandivaLibraryFromJar(final String
tmpDir)
final String libraryToLoad =
LIBRARY_NAME + "/" + getNormalizedArch() + "/" +
System.mapLibraryName(LIBRARY_NAME);
final File libraryFile = moveFileFromJarToTemp(tmpDir, libraryToLoad,
LIBRARY_NAME);
+ NativeLibrary.getInstance(
+ libraryFile.getAbsolutePath(),
+ Collections.singletonMap(Library.OPTION_OPEN_FLAGS, new
Integer(RTLD_LAZY | RTLD_GLOBAL)));
System.load(libraryFile.getAbsolutePath());
Review Comment:
Is this still necessary if we're using the JNA version?
##########
gandiva/src/main/java/org/apache/arrow/gandiva/evaluator/JniLoader.java:
##########
@@ -69,6 +75,9 @@ private static void loadGandivaLibraryFromJar(final String
tmpDir)
final String libraryToLoad =
LIBRARY_NAME + "/" + getNormalizedArch() + "/" +
System.mapLibraryName(LIBRARY_NAME);
final File libraryFile = moveFileFromJarToTemp(tmpDir, libraryToLoad,
LIBRARY_NAME);
+ NativeLibrary.getInstance(
Review Comment:
Doesn't the NativeLibrary instance need to be disposed somewhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
