kszucs commented on code in PR #45688:
URL: https://github.com/apache/arrow/pull/45688#discussion_r1984652520
##########
cpp/src/parquet/column_writer.cc:
##########
@@ -1870,67 +1908,40 @@ struct SerializeFunctor {
}
};
-template <typename ParquetType, typename ArrowType>
-Status WriteArrowSerialize(const ::arrow::Array& array, int64_t num_levels,
- const int16_t* def_levels, const int16_t*
rep_levels,
- ArrowWriteContext* ctx,
TypedColumnWriter<ParquetType>* writer,
- bool maybe_parent_nulls) {
- using ParquetCType = typename ParquetType::c_type;
+template <typename ParquetType>
+template <typename ArrowType>
Review Comment:
Otherwise I am getting:
```
/Users/kszucs/Workspace/arrow/cpp/src/parquet/column_writer.cc:1911:1:
error: too many template parameters in template redeclaration
1911 | template <typename ParquetType, typename ArrowType>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/kszucs/Workspace/arrow/cpp/src/parquet/column_writer.cc:1212:1: note:
previous template declaration is here
1212 | template <typename ParquetType>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
`ParquetType` applies to `TypedColumnWriterImpl` and `ArrowType` is used for
the the method `TypedColumnWriterImpl::WriteArrowSerialize`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
