davidhcoe commented on code in PR #2587:
URL: https://github.com/apache/arrow-adbc/pull/2587#discussion_r1985542992
##########
csharp/src/Drivers/BigQuery/BigQueryStatement.cs:
##########
@@ -349,15 +374,27 @@ sealed class ReadRowsStream : Stream
ReadOnlyMemory<byte> currentBuffer;
bool first;
int position;
+ bool hasRows = true;
public ReadRowsStream(IAsyncEnumerator<ReadRowsResponse> response)
{
if (!response.MoveNextAsync().Result) { }
- this.currentBuffer =
response.Current.ArrowSchema.SerializedSchema.Memory;
+
+ if (response.Current != null)
Review Comment:
A NullReferenceException occurs if there are no results from the query
because response.Current is null. So, this uses an indicator of "HasRows" to
dictate the behavior of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
