kou commented on code in PR #45470:
URL: https://github.com/apache/arrow/pull/45470#discussion_r1986232772
##########
dev/tasks/tasks.yml:
##########
@@ -392,20 +392,22 @@ tasks:
{############################## Wheel Linux ##################################}
-
-{% for arch, manylinux_version, platform_tag in [("amd64", "2014",
"manylinux_2_17_x86_64.manylinux2014_x86_64"),
- ("amd64", "2-28",
"manylinux_2_28_x86_64"),
- ("arm64", "2014",
"manylinux_2_17_aarch64.manylinux2014_aarch64"),
- ("arm64", "2-28",
"manylinux_2_28_aarch64")] %}
- wheel-manylinux-{{ manylinux_version }}-{{ python_tag }}-{{ abi_tag }}-{{
arch }}:
+{% for wheel_kind, arch, version, platform_tag in [("manylinux", "amd64",
"2014", "manylinux_2_17_x86_64.manylinux2014_x86_64"),
+ ("manylinux", "amd64",
"2-28", "manylinux_2_28_x86_64"),
+ ("manylinux", "arm64",
"2014", "manylinux_2_17_aarch64.manylinux2014_aarch64"),
+ ("manylinux", "arm64",
"2-28", "manylinux_2_28_aarch64"),
+ ("musllinux", "amd64", "1-2",
"musllinux_1_2_x86_64"),
+ ("musllinux", "arm64", "1-2",
"musllinux_1_2_aarch64")] %}
+ wheel-{{ wheel_kind }}-{{ version }}-{{ python_tag }}-{{ abi_tag }}-{{ arch
}}:
ci: github
template: python-wheels/github.linux.yml
params:
arch: "{{ arch }}"
python_version: "{{ python_version }}"
python_abi_tag: "{{ abi_tag }}"
- manylinux_version: "{{ manylinux_version }}"
+ linux_wheel_version: "{{ version }}"
wheel_platform_tag: "{{ platform_tag }}"
+ linux_wheel_kind: "{{ wheel_kind }}"
Review Comment:
Could you keep this list in alphabetical order?
##########
ci/docker/python-wheel-musllinux-test.dockerfile:
##########
@@ -0,0 +1,35 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+ARG alpine_linux
+ARG python_image_tag
+FROM python:${python_image_tag}-alpine${alpine_linux}
+
+RUN apk add --no-cache bash g++ linux-headers python3-dev tzdata
Review Comment:
Could you use multi-lines here too?
```suggestion
RUN apk add --no-cache \
bash \
g++ \
linux-headers \
python3-dev \
tzdata
```
##########
ci/docker/python-wheel-musllinux.dockerfile:
##########
@@ -0,0 +1,108 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+ARG base
+FROM ${base}
+
+ARG arch
+ARG arch_short
+ARG musllinux
+
+ENV LINUX_WHEEL_KIND='musllinux'
+ENV LINUX_WHEEL_VERSION=${musllinux}
+
+RUN apk update
+RUN apk add --no-cache build-base ccache cmake curl flex git ninja unzip wget
zip
Review Comment:
Could you use multi-lines here too?
```suggestion
RUN apk add --no-cache \
build-base \
ccache \
cmake \
curl \
flex \
git \
ninja \
unzip \
wget \
zip
```
##########
dev/tasks/tasks.yml:
##########
@@ -392,20 +392,22 @@ tasks:
{############################## Wheel Linux ##################################}
-
-{% for arch, manylinux_version, platform_tag in [("amd64", "2014",
"manylinux_2_17_x86_64.manylinux2014_x86_64"),
- ("amd64", "2-28",
"manylinux_2_28_x86_64"),
- ("arm64", "2014",
"manylinux_2_17_aarch64.manylinux2014_aarch64"),
- ("arm64", "2-28",
"manylinux_2_28_aarch64")] %}
- wheel-manylinux-{{ manylinux_version }}-{{ python_tag }}-{{ abi_tag }}-{{
arch }}:
+{% for wheel_kind, arch, version, platform_tag in [("manylinux", "amd64",
"2014", "manylinux_2_17_x86_64.manylinux2014_x86_64"),
+ ("manylinux", "amd64",
"2-28", "manylinux_2_28_x86_64"),
+ ("manylinux", "arm64",
"2014", "manylinux_2_17_aarch64.manylinux2014_aarch64"),
+ ("manylinux", "arm64",
"2-28", "manylinux_2_28_aarch64"),
+ ("musllinux", "amd64", "1-2",
"musllinux_1_2_x86_64"),
+ ("musllinux", "arm64", "1-2",
"musllinux_1_2_aarch64")] %}
Review Comment:
```suggestion
("manylinux", "amd64",
"2-28", "manylinux_2_28_x86_64"),
("manylinux", "arm64",
"2014", "manylinux_2_17_aarch64.manylinux2014_aarch64"),
("manylinux", "arm64",
"2-28", "manylinux_2_28_aarch64"),
("musllinux", "amd64",
"1-2", "musllinux_1_2_x86_64"),
("musllinux", "arm64",
"1-2", "musllinux_1_2_aarch64")] %}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
