kou commented on code in PR #45706:
URL: https://github.com/apache/arrow/pull/45706#discussion_r1986464824
##########
python/pyarrow/_azurefs.pyx:
##########
@@ -60,6 +61,9 @@ cdef class AzureFileSystem(FileSystem):
dfs_storage_scheme : str, default None
Either `http` or `https`. Defaults to `https`. Useful for connecting
to a local
emulator, like Azurite.
+ sas_token : str, default None
+ Sas token for the storage account, used as an alternative to
account_key. If sas_token
Review Comment:
```suggestion
SAS token for the storage account, used as an alternative to
account_key. If sas_token
```
##########
python/pyarrow/_azurefs.pyx:
##########
@@ -100,6 +105,9 @@ cdef class AzureFileSystem(FileSystem):
if account_key:
options.ConfigureAccountKeyCredential(tobytes(account_key))
self.account_key = tobytes(account_key)
+ elif sas_token:
+ options.ConfigureSASCredential(tobytes(sas_token))
+ self.sas_token = tobytes(sas_token)
Review Comment:
Should we prefer `sas_token` to `account_key`?
(SAS token is safer than account key, right?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
