sumimakito commented on code in PR #45712:
URL: https://github.com/apache/arrow/pull/45712#discussion_r1986400774
##########
js/test/unit/builders/utf8-tests.ts:
##########
@@ -47,7 +47,7 @@ function runTestsWithEncoder(name: string, encode: (vals:
(string | null)[], nul
describe(`${encode.name} ${name}`, () => {
it(`encodes strings no nulls`, async () => {
const vals = stringsNoNulls(20);
- validateVector(vals, await encode(vals, []), []);
+ validateVector(vals, await encode([], []), []);
Review Comment:
@trxcllnt I'm not sure about that either and I just noticed it. It seems
this change was authored by @handstuyennn before. Would you mind me reverting
this line and re-running the tests for another pass?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
