kou commented on code in PR #2588:
URL: https://github.com/apache/arrow-adbc/pull/2588#discussion_r1986584911
##########
c/driver_manager/CMakeLists.txt:
##########
@@ -30,16 +30,16 @@ add_arrow_lib(adbc_driver_manager
${CMAKE_DL_LIBS}
SHARED_LINK_FLAGS
${ADBC_LINK_FLAGS})
-include_directories(SYSTEM ${REPOSITORY_ROOT}/c/)
-include_directories(SYSTEM ${REPOSITORY_ROOT}/c/include/)
-include_directories(SYSTEM ${REPOSITORY_ROOT}/c/vendor)
-include_directories(SYSTEM ${REPOSITORY_ROOT}/c/driver)
install(FILES "${REPOSITORY_ROOT}/c/include/adbc.h" DESTINATION include)
install(FILES "${REPOSITORY_ROOT}/c/include/arrow-adbc/adbc.h"
DESTINATION include/arrow-adbc)
foreach(LIB_TARGET ${ADBC_LIBRARIES})
+ target_include_directories(${LIB_TARGET} SYSTEM PRIVATE
${REPOSITORY_ROOT}/c/)
+ target_include_directories(${LIB_TARGET} SYSTEM PRIVATE
${REPOSITORY_ROOT}/c/include/)
+ target_include_directories(${LIB_TARGET} SYSTEM PRIVATE
${REPOSITORY_ROOT}/c/vendor)
+ target_include_directories(${LIB_TARGET} SYSTEM PRIVATE
${REPOSITORY_ROOT}/c/driver)
Review Comment:
```suggestion
target_include_directories(${LIB_TARGET} SYSTEM PRIVATE
${REPOSITORY_ROOT}/c/)
${REPOSITORY_ROOT}/c/include/
${REPOSITORY_ROOT}/c/vendor
${REPOSITORY_ROOT}/c/driver)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
