pitrou commented on code in PR #45577: URL: https://github.com/apache/arrow/pull/45577#discussion_r1988661235
########## cpp/src/arrow/compute/kernels/scalar_string_ascii.cc: ########## @@ -2308,9 +2313,8 @@ struct ExtractRegex : public ExtractRegexBase { RETURN_NOT_OK(field_builders[i]->Append(ToStringView(found_values[i]))); } return struct_builder->Append(); - } else { - return struct_builder->AppendNull(); } + return struct_builder->AppendNull(); Review Comment: What do you mean? You just have to move two lines of code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org