pitrou commented on code in PR #45743:
URL: https://github.com/apache/arrow/pull/45743#discussion_r1989106603
##########
python/pyarrow/src/arrow/python/deserialize.cc:
##########
@@ -321,183 +321,5 @@ Status DeserializeSet(PyObject* context, const Array&
array, int64_t start_idx,
out);
}
Review Comment:
Is the rest of the file still being used? I would expect us to entirely
remove `deserialize.h` and `deserialize.cc`.
##########
python/pyarrow/src/arrow/python/serialize.cc:
##########
@@ -585,19 +585,6 @@ std::shared_ptr<RecordBatch>
MakeBatch(std::shared_ptr<Array> data) {
return RecordBatch::Make(schema, data->length(), {data});
}
Review Comment:
Same question for `serialize.h` and `serialize.cc`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
