nevi-me commented on a change in pull request #9831:
URL: https://github.com/apache/arrow/pull/9831#discussion_r603020195
##########
File path: cpp/src/parquet/parquet_version.h.in
##########
@@ -18,14 +18,16 @@
#ifndef PARQUET_VERSION_H
#define PARQUET_VERSION_H
-#define PARQUET_VERSION_MAJOR @PARQUET_VERSION_MAJOR@
-#define PARQUET_VERSION_MINOR @PARQUET_VERSION_MINOR@
-#define PARQUET_VERSION_PATCH @PARQUET_VERSION_PATCH@
+#include "arrow/util/config.h"
+
+#define PARQUET_VERSION_MAJOR @ARROW_VERSION_MAJOR@
+#define PARQUET_VERSION_MINOR @ARROW_VERSION_MINOR@
+#define PARQUET_VERSION_PATCH @ARROW_VERSION_PATCH@
#define PARQUET_SO_VERSION "@ARROW_SO_VERSION@"
#define PARQUET_FULL_SO_VERSION "@ARROW_FULL_SO_VERSION@"
// define the parquet created by version
-#define CREATED_BY_VERSION "parquet-cpp version @PARQUET_VERSION@"
+#define CREATED_BY_VERSION "parquet-cpp-arrow version @ARROW_VERSION@"
Review comment:
Is it useful to also add the git commit SHA? I can't tell if it gets
added, from looking at the change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
