alamb commented on code in PR #6637:
URL: https://github.com/apache/arrow-rs/pull/6637#discussion_r1989945554
##########
parquet/src/arrow/async_reader/mod.rs:
##########
@@ -2336,4 +2459,279 @@ mod tests {
let result = reader.try_collect::<Vec<_>>().await.unwrap();
assert_eq!(result.len(), 1);
}
+
+ #[tokio::test]
Review Comment:
As they are placed here, these tests:
1. Require `#[cfg(feature = "encryption")]` for each
2. Have different visibility rules than user programs (they can use non
public items from the containing module)
Thus I recommend we move the tests to the `reader` "integration test" --
https://github.com/apache/arrow-rs/tree/main/parquet/tests/arrow_reader
This is what gets run via `cargo test -p parquet --test arrow_reader`
We can basically follow the same pattern as checksumming
https://github.com/apache/arrow-rs/blob/f4fde769ab6e1a9b75f890b7f8b47bc22800830b/parquet/tests/arrow_reader/mod.rs#L39-L40
I think the way this PR has it is fine, however, and I think we should move
the tests as part of a follow on PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
