arashandishgar commented on PR #45663:
URL: https://github.com/apache/arrow/pull/45663#issuecomment-2718449700
@kou When I run `IWYU` on record_batch.cc on `record_batch.cc` I got the
following message. Should I pay attention ton
```
/media/arashandishgar/7ea4b859-cfd7-41cb-8466-dc8dbc34284b/ARROW/arrow/cpp/iwyu$
$IWYU_SH match arrow/record_batch.cc
include-what-you-use 0.18 (git:abd5d2b) based on Ubuntu clang version 14.0.6
Running IWYU on
/media/arashandishgar/7ea4b859-cfd7-41cb-8466-dc8dbc34284b/ARROW/arrow/cpp/src/arrow/record_batch.cc
/media/arashandishgar/7ea4b859-cfd7-41cb-8466-dc8dbc34284b/ARROW/arrow/cpp/src/arrow/record_batch.h
should add these lines:
#include <iosfwd> // for ptrdiff_t
#include <iterator> // for input_iterator_tag
#include "arrow/util/compare.h" // for operator==
namespace arrow { class Array; }
namespace arrow { class Field; }
namespace arrow { class KeyValueMetadata; }
namespace arrow { class MemoryPool; }
namespace arrow { class Schema; }
namespace arrow { class StructArray; }
namespace arrow { class Table; }
namespace arrow { class Tensor; }
namespace arrow { struct ArrayData; }
namespace arrow { template <typename T> class Iterator; }
namespace arrow { template <typename T> struct IterationTraits; }
/media/arashandishgar/7ea4b859-cfd7-41cb-8466-dc8dbc34284b/ARROW/arrow/cpp/src/arrow/record_batch.h
should remove these lines:
- #include "arrow/util/iterator.h" // lines 30-30
/media/arashandishgar/7ea4b859-cfd7-41cb-8466-dc8dbc34284b/ARROW/arrow/cpp/src/arrow/record_batch.cc
should add these lines:
#include <string.h> // for strlen
#include <functional> // for function
#include <optional> // for optional, nullopt
#include <variant> // for variant, visit
#include "arrow/array/array_base.h" // for Array
#include "arrow/array/array_nested.h" // for StructArray
#include "arrow/array/data.h" // for ArrayData
#include "arrow/array/statistics.h" // for ArrayStatistics,
ArrayStatis...
#include "arrow/array/util.h" // for MakeArray, MakeEmptyArray
#include "arrow/util/checked_cast.h" // for checked_pointer_cast
namespace arrow { class KeyValueMetadata; }
namespace arrow { class MemoryPool; }
namespace arrow { struct Scalar; }
/media/arashandishgar/7ea4b859-cfd7-41cb-8466-dc8dbc34284b/ARROW/arrow/cpp/src/arrow/record_batch.cc
should remove these lines:
- #include <atomic> // lines 21-21
- #include <cmath> // lines 22-22
- #include "arrow/array.h" // lines 29-29
- #include "arrow/visit_type_inline.h" // lines 45-45
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
