raulcd commented on code in PR #45738:
URL: https://github.com/apache/arrow/pull/45738#discussion_r1990961416
##########
dev/release/verify-release-candidate.sh:
##########
@@ -181,95 +181,123 @@ test_binary() {
verify_dir_artifact_signatures ${download_dir}
}
+check_verification_result_on_github() {
+ pushd ${ARROW_TMPDIR}
+ curl \
+ --get \
+ --data "branch=apache-arrow-${VERSION}-rc${RC_NUMBER}" \
+
"https://api.github.com/repos/apache/arrow/actions/workflows/verify_rc.yml/runs";
| \
+ jq '.workflow_runs[0]' > latest_verify_rc.json
+ conclusion="$(jq -r '.conclusion' latest_verify_rc.json)"
+ if [ "${conclusion}" != "success" ]; then
+ html_url="$(jq -r '.html_url' latest_verify_rc.json)"
+ echo "Verification on GitHub wasn't succeeded: ${conclusion}: ${html_url}"
+ exit 1
+ fi
+ popd
+}
+
test_apt() {
show_header "Testing APT packages"
- if [ "$(arch)" = "x86_64" ]; then
- for target in "debian:bookworm" \
- "debian:trixie" \
- "ubuntu:jammy" \
- "ubuntu:noble"; do \
- if ! docker run \
- --platform=linux/x86_64 \
- --rm \
- --security-opt="seccomp=unconfined" \
- --volume "${ARROW_DIR}":/arrow:delegated \
- "${target}" \
- /arrow/dev/release/verify-apt.sh \
- "${VERSION}" \
- "rc"; then
- echo "Failed to verify the APT repository for ${target} on x86_64"
- exit 1
- fi
- done
+ if [ "${GITHUB_ACTIONS}" != "true" ]; then
+ check_verification_result_on_github
+ return 0
fi
- if [ "$(arch)" = "aarch64" -o -e /usr/bin/qemu-aarch64-static ]; then
- for target in "arm64v8/debian:bookworm" \
- "arm64v8/debian:trixie" \
- "arm64v8/ubuntu:jammy" \
- "arm64v8/ubuntu:noble"; do \
- if ! docker run \
- --platform=linux/arm64 \
- --rm \
- --security-opt="seccomp=unconfined" \
- --volume "${ARROW_DIR}":/arrow:delegated \
- "${target}" \
- /arrow/dev/release/verify-apt.sh \
- "${VERSION}" \
- "rc"; then
- echo "Failed to verify the APT repository for ${target} on arm64"
- exit 1
- fi
- done
- fi
+ case "$(arch)" in
Review Comment:
nice improvement with the `case`. Thanks @kou
##########
dev/release/verify-release-candidate.sh:
##########
@@ -181,95 +181,123 @@ test_binary() {
verify_dir_artifact_signatures ${download_dir}
}
+check_verification_result_on_github() {
+ pushd ${ARROW_TMPDIR}
+ curl \
+ --get \
+ --data "branch=apache-arrow-${VERSION}-rc${RC_NUMBER}" \
+
"https://api.github.com/repos/apache/arrow/actions/workflows/verify_rc.yml/runs";
| \
+ jq '.workflow_runs[0]' > latest_verify_rc.json
+ conclusion="$(jq -r '.conclusion' latest_verify_rc.json)"
+ if [ "${conclusion}" != "success" ]; then
+ html_url="$(jq -r '.html_url' latest_verify_rc.json)"
+ echo "Verification on GitHub wasn't succeeded: ${conclusion}: ${html_url}"
Review Comment:
```suggestion
echo "Verification on GitHub wasn't successful: ${conclusion}:
${html_url}"
```
or
```
echo "Verification on GitHub didn't succeed: ${conclusion}: ${html_url}"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
