pitrou commented on code in PR #45763:
URL: https://github.com/apache/arrow/pull/45763#discussion_r1995126759
##########
cpp/src/arrow/compute/kernels/aggregate_quantile.cc:
##########
@@ -524,23 +530,13 @@ void AddQuantileKernels(VectorFunction* func) {
base.signature = KernelSignature::Make({InputType(ty)},
OutputType(ResolveOutput));
// output type is determined at runtime, set template argument to nulltype
base.exec = GenerateNumeric<QuantileExecutor, NullType>(*ty);
- base.exec_chunked =
- GenerateNumeric<QuantileExecutorChunked, NullType,
VectorKernel::ChunkedExec>(
- *ty);
- DCHECK_OK(func->AddKernel(base));
- }
- {
- base.signature =
- KernelSignature::Make({InputType(Type::DECIMAL128)},
OutputType(ResolveOutput));
- base.exec = QuantileExecutor<NullType, Decimal128Type>::Exec;
- base.exec_chunked = QuantileExecutorChunked<NullType,
Decimal128Type>::Exec;
+ base.exec_chunked = GenerateNumeric<QuantileExecutorChunked,
NullType>(*ty);
DCHECK_OK(func->AddKernel(base));
}
- {
- base.signature =
- KernelSignature::Make({InputType(Type::DECIMAL256)},
OutputType(ResolveOutput));
- base.exec = QuantileExecutor<NullType, Decimal256Type>::Exec;
- base.exec_chunked = QuantileExecutorChunked<NullType,
Decimal256Type>::Exec;
+ for (auto type_id : DecimalTypeIds()) {
Review Comment:
Not entirely independent, since it's necessary for `winsorize` itself to
work on those types
(and it's mentioned in the PR description :)).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
