zanmato1984 commented on code in PR #45701:
URL: https://github.com/apache/arrow/pull/45701#discussion_r1995118776
##########
cpp/src/arrow/compute/expression.cc:
##########
@@ -220,6 +220,7 @@ void PrintTo(const Expression& expr, std::ostream* os) {
bool Expression::Equals(const Expression& other) const {
if (Identical(*this, other)) return true;
+ if (impl_ == nullptr || other.impl_ == nullptr) return false;
Review Comment:
Just for complying with the existing style: each returning branch is
separated by a blank line.
##########
cpp/src/arrow/compute/expression.cc:
##########
@@ -220,6 +220,7 @@ void PrintTo(const Expression& expr, std::ostream* os) {
bool Expression::Equals(const Expression& other) const {
if (Identical(*this, other)) return true;
+ if (impl_ == nullptr || other.impl_ == nullptr) return false;
Review Comment:
```suggestion
if (impl_ == nullptr || other.impl_ == nullptr) return false;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
