WillAyd commented on code in PR #45797:
URL: https://github.com/apache/arrow/pull/45797#discussion_r1997170811
##########
cpp/src/arrow/meson.build:
##########
@@ -238,11 +238,7 @@ if needs_integration or needs_tests
}
endif
-if needs_json
- rapidjson_dep = dependency('rapidjson', include_type: 'system')
-else
- rapidjson_dep = disabler()
-endif
+rapidjson_dep = dependency('rapidjson', include_type: 'system')
Review Comment:
The integration tests requires RapidJSON but does not require the JSON
option to be set, so to get that to work without disabling the integration test
I think this need to exist without branching
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
