ianmcook commented on a change in pull request #8990:
URL: https://github.com/apache/arrow/pull/8990#discussion_r603563736
##########
File path: cpp/src/arrow/compute/kernels/scalar_string_test.cc
##########
@@ -428,6 +433,26 @@ TYPED_TEST(TestStringKernels,
StrptimeDoesNotProvideDefaultOptions) {
ASSERT_RAISES(Invalid, CallFunction("strptime", {input}));
}
+TYPED_TEST(TestStringKernels, Join) {
+ auto separator = this->scalar("--");
+ CheckScalarBinary(
+ "binary_join", list(this->type()),
+ R"([["a", "bb", "ccc"], [], null, ["dd"], ["eee", null], ["ff", ""]])",
separator,
+ this->type(), R"(["a--bb--ccc", "", null, "dd", null, "ff--"])");
Review comment:
Regarding the R bindings: we will need some additional things beyond the
scope of this PR to implement useful translations for `paste()` and
`str_c()`—most importantly, a way of combining two or more arrays row-wise into
list arrays (because in most real-world usage the strings users want to combine
won't be in a list array). So I think it's fine to save those considerations
for later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
