mbutrovich commented on code in PR #7285:
URL: https://github.com/apache/arrow-rs/pull/7285#discussion_r1999242847
##########
parquet/src/record/api.rs:
##########
@@ -701,7 +701,7 @@ impl Field {
/// `Timestamp` value.
#[inline]
pub fn convert_int96(_descr: &ColumnDescPtr, value: Int96) -> Self {
- Field::TimestampMillis(value.to_i64())
+ Field::TimestampMillis(value.to_millis())
Review Comment:
Yeah I found this whole `to_64` and to `convert_i96` logic bizarre and am
not sure how anyone is using it. Current behavior for `convert_i96` has it call
`to_i64` which converts to millis, so I tried to keep the behavior the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
