kszucs commented on issue #45817:
URL: https://github.com/apache/arrow/issues/45817#issuecomment-2729480987
Also the `type_id` functions are not always consistent named with the
template conditions, see:
```cpp
/// \brief Check for a binary-like type (i.e. with 32-bit offsets)
///
/// \param[in] type_id the type-id to check
/// \return whether type-id is a binary-like type one
constexpr bool is_binary_like(Type::type type_id) {
switch (type_id) {
case Type::BINARY:
case Type::STRING:
return true;
default:
break;
}
return false;
}
```
and the identically named:
```cpp
template <typename T>
using is_binary_like_type =
std::integral_constant<bool, (is_base_binary_type<T>::value &&
!is_string_like_type<T>::value) ||
is_fixed_size_binary_type<T>::value>;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
