kszucs commented on code in PR #45360:
URL: https://github.com/apache/arrow/pull/45360#discussion_r1999426963
##########
cpp/src/parquet/properties.h:
##########
@@ -275,10 +282,33 @@ class PARQUET_EXPORT WriterProperties {
page_checksum_enabled_(properties.page_checksum_enabled()),
size_statistics_level_(properties.size_statistics_level()),
sorting_columns_(properties.sorting_columns()),
- default_column_properties_(properties.default_column_properties()) {}
+ default_column_properties_(properties.default_column_properties()),
+ cdc_enabled_(properties.cdc_enabled()),
+ cdc_size_range_(properties.cdc_size_range()),
+ cdc_norm_factor_(properties.cdc_norm_factor()) {}
virtual ~Builder() {}
+ Builder* enable_cdc() {
Review Comment:
I spelled it out everywhere. It is a little bit verbose, but definitely less
confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
