adriangb commented on code in PR #7015:
URL: https://github.com/apache/arrow-rs/pull/7015#discussion_r1999797429
##########
arrow-json/src/writer/encoder.rs:
##########
@@ -362,42 +480,36 @@ impl<O: OffsetSizeTrait> Encoder for ListEncoder<'_, O> {
let end = self.offsets[idx + 1].as_usize();
let start = self.offsets[idx].as_usize();
out.push(b'[');
- match self.nulls.as_ref() {
- Some(n) => (start..end).for_each(|idx| {
- if idx != start {
- out.push(b',')
- }
- match n.is_null(idx) {
- true => out.extend_from_slice(b"null"),
- false => self.encoder.encode(idx, out),
- }
- }),
- None => (start..end).for_each(|idx| {
- if idx != start {
- out.push(b',')
- }
+
Review Comment:
Okay will try to reproduce the slowdown tomorrow and address it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
