pitrou commented on code in PR #45762:
URL: https://github.com/apache/arrow/pull/45762#discussion_r2000396309
##########
python/pyarrow/_compute.pyx:
##########
@@ -1920,11 +1920,14 @@ class SkewOptions(_SkewOptions):
Parameters
----------
{_skip_nulls_doc()}
+ biased : bool, default True
+ Whether the calculated value is biased.
+ If False, the value computed includes a corrections factor to reduce
bias.
Review Comment:
Nit: "correction factor" perhaps? (singular)
##########
python/pyarrow/tests/test_compute.py:
##########
@@ -3838,3 +3838,18 @@ def test_pivot_wider():
with pytest.raises(ValueError, match="Encountered more than one non-null
value"):
result = pc.pivot_wider(["height", "width", "height"], [10, None, 11],
key_names=key_names)
+
+
[email protected]("input, expected", (
+ (
+ [1.0, 2.0, 3.0, 40.0, None],
+ {'skew': 1.988947740397821, 'kurtosis': 3.9631931024230695}
+ ),
+ ([1, 2, 40], {'skew': 1.7281098503730385, 'kurtosis': None}),
+ ([1, 40], {'skew': None, 'kurtosis': None}),
+))
+def test_unbiased_skew_and_kurtosis(input, expected):
Review Comment:
Nit: can we move this test near the existing skew/kurtosis tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
