adamreeve commented on PR #44990: URL: https://github.com/apache/arrow/pull/44990#issuecomment-2732279139
> Is there still a need to open a follow-up issue for "... keys being wiped out if they're set explicitly rather than using a key retriever.": [#44990 (comment)](https://github.com/apache/arrow/pull/44990#discussion_r1953634919)? I tried to see if I could make this cause a crash, but there are other checks for re-using encryption properties or decryption properties that disallow explicitly specifying encryption/decryption keys when using a Dataset. Eg. at https://github.com/apache/arrow/blob/550a6b3c5630f44683f8fcae866d935028fd566c/cpp/src/parquet/encryption/internal_file_encryptor.cc#L48 and https://github.com/apache/arrow/blob/550a6b3c5630f44683f8fcae866d935028fd566c/cpp/src/parquet/encryption/internal_file_decryptor.cc#L62 So I don't think this follow-up issue is needed. For reference, this is what I tried: https://github.com/adamreeve/arrow/commit/5a04f80c0747bac2ea3166741f80793a68bf86e0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
