raulcd commented on issue #45820:
URL: https://github.com/apache/arrow/issues/45820#issuecomment-2732840895
I've started taking a look at this. Would you deprecate the existing
`CopyBitmap` function and force the new variant or provide both APIs?
```diff
+++ b/cpp/src/arrow/util/bitmap_ops.h
@@ -41,10 +41,27 @@ namespace internal {
/// \param[in] length number of bits to copy
///
/// \return Status message
+///
+/// \deprecated Deprecated in 20.0.0. Use version with dest_offset
parameter.
+ARROW_DEPRECATED("Deprecated in 20.0.0. Use version with dest_offset
parameter.")
ARROW_EXPORT
Result<std::shared_ptr<Buffer>> CopyBitmap(MemoryPool* pool, const uint8_t*
bitmap,
int64_t offset, int64_t length);
+
+/// Copy a bit range of an existing bitmap
+///
+/// \param[in] pool memory pool to allocate memory from
+/// \param[in] bitmap source data
+/// \param[in] offset bit offset into the source data
+/// \param[in] length number of bits to copy
+/// \param[in] length number of bits to copy
+/// \param[in] dest_offset bit offset into the destination
+/// \return Status message
+ARROW_EXPORT
+Result<std::shared_ptr<Buffer>> CopyBitmap(MemoryPool* pool, const uint8_t*
bitmap,
+ int64_t offset, int64_t length,
int64_t dest_offset);
+
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
