tustvold commented on code in PR #7308:
URL: https://github.com/apache/arrow-rs/pull/7308#discussion_r2002126340
##########
arrow-buffer/src/builder/null.rs:
##########
@@ -179,6 +179,20 @@ impl NullBufferBuilder {
}
}
+ /// Append [`NullBuffer`] to this [`NullBufferBuilder`]
+ ///
+ /// This is useful when you want to concatenate two null buffers.
+ pub fn append_buffer(&mut self, buffer: &NullBuffer) {
+ if buffer.null_count() > 0 {
+ self.materialize_if_needed();
+ }
+ if let Some(buf) = self.bitmap_builder.as_mut() {
Review Comment:
I believe this should be covered by the line above that calls
materialize_if_needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
