paleolimbot commented on issue #726: URL: https://github.com/apache/arrow-nanoarrow/issues/726#issuecomment-2734814290
That's very kind of you! I've currently hit the stage in the CMake refactoring where I never want to write CMake ever again but I'll almost certainly recover if you don't have the chance to circle back: Some other ideas from #719 that weren't implemented there: For packaging the shared bit could be made a component that also changes which target gets the main alias. (again something gflags does find_package(gflags COMPONENTS shared) nit: You should be able to create an INTERFACE target for the sources and use that instead of variables: https://cmake.org/cmake/help/latest/prop_tgt/INTERFACE_SOURCES.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
