eli-schwartz commented on code in PR #45858:
URL: https://github.com/apache/arrow/pull/45858#discussion_r2002557632
##########
ci/scripts/cpp_build.sh:
##########
@@ -118,12 +118,20 @@ if [ "${ARROW_USE_MESON:-OFF}" = "ON" ]; then
fi
}
+ ORIGINAL_CXX=${CXX}
Review Comment:
Many people recommend always quoting variables for stylistic reasons. That
being said, this is a variable assignment. Variable assignments do perform
tilde expansion, parameter expansion, command substitution, arithmetic
expansion, and quote removal, but they don't perform field splitting. Quoting
the right hand side is not necessary to prevent field splitting.
(In the case of `CXX="ccache ${CXX}"` the quotes do not do field splitting
but rather, field joining. :slightly_smiling_face: )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
