cyb70289 edited a comment on pull request #9841:
URL: https://github.com/apache/arrow/pull/9841#issuecomment-809853074


   > I'm not sure about two things:
   > 
   >     * Is `Exponentiate` a good name or should we go with `Power`? I picked 
`Exponentiate` as all the other operation names are verbs so `Power` feels 
inconsistent.
   
   I prefer `power` which is used widely. But I'm bad at naming, so would like 
to hear other comments.
   
   > 
   >     * Should we add overflow checking logic?
   
   I don't think so. Let it be `infinity` looks okay.
   [EDIT] We do not need to check floating point overflow. But I think it's 
necessary for integers, like other arithmetic kernel does.
   
   PS: Numpy checks floating point overflow, but not integer overflow. Looks 
strange to me.
   ```
   In [2]: np.power(10, 1000)
   Out[2]: 0
   
   In [3]: np.power(10.0, 1000)
   <ipython-input-20-202eedf3dc47>:1: RuntimeWarning: overflow encountered in 
power
     np.power(10.0, 1000)
   Out[3]: inf
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to