raulcd commented on code in PR #45852:
URL: https://github.com/apache/arrow/pull/45852#discussion_r2002895455
##########
cpp/src/arrow/util/bitmap_ops.cc:
##########
@@ -215,17 +215,19 @@ void ReverseBlockOffsets(const uint8_t* data, int64_t
offset, int64_t length,
template <TransferMode mode>
Result<std::shared_ptr<Buffer>> TransferBitmap(MemoryPool* pool, const
uint8_t* data,
- int64_t offset, int64_t length)
{
- ARROW_ASSIGN_OR_RAISE(auto buffer, AllocateEmptyBitmap(length, pool));
+ int64_t offset, int64_t length,
+ int64_t out_offset) {
+ const int64_t phys_bits = length + out_offset;
+ ARROW_ASSIGN_OR_RAISE(auto buffer, AllocateEmptyBitmap(phys_bits, pool));
uint8_t* dest = buffer->mutable_data();
- TransferBitmap<mode>(data, offset, length, 0, dest);
+ TransferBitmap<mode>(data, offset, length, out_offset, dest);
// As we have freshly allocated this bitmap, we should take care of zeroing
the
// remaining bits.
Review Comment:
I've tried removing it and all tests are successful
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
