kou commented on issue #45808: URL: https://github.com/apache/arrow/issues/45808#issuecomment-2739049476
In general, we can use anonymous namespace but CMake's unity build https://cmake.org/cmake/help/latest/prop_tgt/UNITY_BUILD.html may cause a problem with anonymous namespace. If there are same definitions in anonymous namespaces in different `.cc`, it causes a redefinition error with CMake's unity build. We need to use `XXX_detail` (or something) namespaces for the case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
