fsdvh opened a new issue, #66:
URL: https://github.com/apache/arrow-rs-object-store/issues/66

   In the current implementation `finish` will consume our writer and in case 
of an error during the finish call we wound be able to abort our write.
   
   I suggest changing the following:
   
   ```rust
   pub async fn finish(mut self) -> Result<PutResult>
   ```
   to something like this:
   
   ```rust
   pub async fn finish(&mut self) -> Result<PutResult>
   ```
   
   To be able to call the abort method after that
   
   We potentially can safeguard ourselves from multiple finish calls by adding 
an `is_finished` flag to the writer
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to