Silemo opened a new issue, #75:
URL: https://github.com/apache/arrow-rs-object-store/issues/75

   **Is your feature request related to a problem or challenge? Please describe 
what you are trying to do.**
   <!--
   A clear and concise description of what the problem is. Ex. I'm always 
frustrated when [...] 
   (This section helps Arrow developers understand the context and *why* for 
this feature, in addition to  the *what*)
   -->
   Hi young dev here! 
   
   I am currently busy doing an external implementation (or to phrase it 
better, I am essential refactoring the 
[datafusion-contrib/datafusion-objectstore-hdfs](https://github.com/datafusion-contrib/datafusion-objectstore-hdfs)
 repository to support the latest 0.10 object store interface. 
   
   While my src implementation is complete, I am still lacking the tests. While 
looking at the implementation of the `object_store` interface in this 
repository, I've noticed that most of tests in ObjectStore implementations 
(`Local`, `Azure` etc.) call test functions defined in 
`object_store/src/lib.rs`. These tests offer a crate visibility, so even thou 
my implementation would benefit from it, I can't access it.
   
   After a brief discussion with @tustvold, he suggested to generalise my need 
to create a suite of shared integration tests across object_store 
implementations.
   
   **Describe the solution you'd like**
   <!--
   A clear and concise description of what you want to happen.
   -->
   This solution comprises of mainly two points
   - [ ] Move the tests from the source files to a mirror into `/tests` folder
   - [ ] Change the visibility (from `pub(crate)` to `pub`) of test functions, 
ensuring this change is not in conflict with private accesses.
   
   **Describe alternatives you've considered**
   <!--
   A clear and concise description of any alternative solutions or features 
you've considered.
   -->
   Alternatives to this feature would be to decouple the tests (completely 
refactor what is the current status of the repository) leading to code 
repetition (tests are doing a similar task, even for different implementations.
   
   If there is no will of maintaining these tests (making them public), any 
external implementation of the object_store interface should resort to a 
copy-paste of the functions currently present (code duplication).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to