zeroshade commented on code in PR #323:
URL: https://github.com/apache/arrow-go/pull/323#discussion_r2007817912
##########
arrow/ipc/reader.go:
##########
@@ -36,12 +36,15 @@ import (
// Reader expects a schema (plus any dictionaries) as the first messages
// in the stream, followed by records.
type Reader struct {
+ // refCount needs to be 64-bit aligned
+ // https://pkg.go.dev/sync/atomic#pkg-note-BUG
+ refCount int64
Review Comment:
does this actually ensure alignment? Or should we use atomic.Int64 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
