mbrobbel commented on code in PR #7314:
URL: https://github.com/apache/arrow-rs/pull/7314#discussion_r2008226900


##########
README.md:
##########
@@ -87,6 +87,16 @@ Planned Release Schedule
 | Feb 2025         | `0.12.0` | Major, potentially breaking API changes |
 | Apr 2025         | `0.12.1` | Minor, NO breaking API changes          |
 
+### Rust Version Compatibility Policy
+
+arrow-rs, parquet and object_store is built and tested with stable rust, and 
will keep a rolling MSRV(minimum supported rust version) which can only be 
updated in major releases on a need by basis (e.g project dependencies bump 
their MSRV or a particular rust feature is useful for us etc..). The new MSRV 
if selected will be at least 6 months old. The minor releases are guaranteed to 
have the same MSRV.

Review Comment:
   ```suggestion
   arrow-rs, parquet and object_store are built and tested with stable Rust, 
and will keep a rolling MSRV (minimum supported Rust version) that can only be 
updated in major releases on a need by basis (e.g. project dependencies bump 
their MSRV or a particular Rust feature is useful for us etc.). The new MSRV if 
selected will be at least 6 months old. The minor releases are guaranteed to 
have the same MSRV.
   ```



##########
README.md:
##########
@@ -87,6 +87,16 @@ Planned Release Schedule
 | Feb 2025         | `0.12.0` | Major, potentially breaking API changes |
 | Apr 2025         | `0.12.1` | Minor, NO breaking API changes          |
 
+### Rust Version Compatibility Policy
+
+arrow-rs, parquet and object_store is built and tested with stable rust, and 
will keep a rolling MSRV(minimum supported rust version) which can only be 
updated in major releases on a need by basis (e.g project dependencies bump 
their MSRV or a particular rust feature is useful for us etc..). The new MSRV 
if selected will be at least 6 months old. The minor releases are guaranteed to 
have the same MSRV.

Review Comment:
   > The minor releases are guaranteed to have the same MSRV.
   
   Isn't this implied by: "can only be updated in major releases"?



##########
README.md:
##########
@@ -87,6 +87,16 @@ Planned Release Schedule
 | Feb 2025         | `0.12.0` | Major, potentially breaking API changes |
 | Apr 2025         | `0.12.1` | Minor, NO breaking API changes          |
 
+### Rust Version Compatibility Policy
+
+arrow-rs, parquet and object_store is built and tested with stable rust, and 
will keep a rolling MSRV(minimum supported rust version) which can only be 
updated in major releases on a need by basis (e.g project dependencies bump 
their MSRV or a particular rust feature is useful for us etc..). The new MSRV 
if selected will be at least 6 months old. The minor releases are guaranteed to 
have the same MSRV.
+
+Note: If a Rust hotfix is released for the current MSRV, the MSRV will be 
updated to the specific minor version that includes all applicable hotfixes 
preceding other policies.
+
+E.g
+
+in Apr 2025 we will release version 55.0.0 which might have a version bump. 
But the rust version selected in this case will be at most version 1.81

Review Comment:
   ```suggestion
   in Apr 2025 we will release version 55.0.0 which might have a version bump. 
But the Rust version selected in this case will be at most version 1.81.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to