pitrou commented on a change in pull request #9843:
URL: https://github.com/apache/arrow/pull/9843#discussion_r604057856
##########
File path: dev/archery/archery/tests/test_benchmarks.py
##########
@@ -94,10 +94,16 @@ def test_static_runner_from_json():
archery_result['suites'][0]['benchmarks'][0]['values'][0] *= 2
baseline = StaticBenchmarkRunner.from_json(json.dumps(archery_result))
- artificial_reg, normal = RunnerComparator(contender, baseline).comparisons
+ comparisons = list(RunnerComparator(contender, baseline).comparisons)
Review comment:
Why not explicitly sort the results? Assuming the benchmark name is
available somewhere in the comparisons objects, this would allow making the
ordering deterministic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
