jkosh44 commented on code in PR #257:
URL:
https://github.com/apache/arrow-rs-object-store/pull/257#discussion_r2008776349
##########
src/gcp/client.rs:
##########
@@ -516,9 +516,7 @@ impl GoogleCloudStorageClient {
if completed_parts.is_empty() {
// GCS doesn't allow empty multipart uploads
let result = self
- .request(Method::PUT, path)
- .idempotent(true)
- .do_put()
+ .put(path, PutPayload::new(), Default::default())
.await?;
self.multipart_cleanup(path, multipart_id).await?;
Review Comment:
@tustvold I was also trying to think about how to make this more obvious.
Perhaps the following structure is more clear? The comment clarifies that we're
falling back to a non-multipart upload. Also moving the PUT after the cleanup
makes it clear that the cleanup is not affecting the PUT. What do you think?
```rust
// GCS doesn't allow empty multipart uploads, so fallback to
regular upload.
self.multipart_cleanup(path, multipart_id).await?;
let result = self
.put(path, PutPayload::new(), Default::default())
.await?;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
