wjones127 commented on code in PR #45889:
URL: https://github.com/apache/arrow/pull/45889#discussion_r2010806861
##########
js/test/unit/vector/vector-tests.ts:
##########
@@ -323,3 +323,40 @@ function basicVectorTests(vector: Vector, values: any[],
extras: any[]) {
}
});
}
+
+// GH-45862: Make sure vectorFromArray produces the correct result for
+// FixedSizeList with null slots
+describe(`vecorFromArray() with FixedSizeList<T> and null slots`, () => {
+ test(`correct child length with null slot first`, () => {
+ let vector = vectorFromArray(
+ [null, [1, 2, 3]],
+ new FixedSizeList(3, new Field('item', new Int32())),
+ );
+ let child = vector.getChildAt(0);
+
+ expect(child).toHaveLength(6);
+ expect(child?.nullCount).toBe(3);
Review Comment:
Thanks for the clarification. [I reported this
issue](https://github.com/apache/arrow/issues/45862) because I found the Arrow
Rust implementation was rejecting the IPC batches being produced by this code
path. I was worried that the nullability would cause incompatibilities as well,
but I've just done some additional tests and it doesn't seem to be an issue.
I'm good with merging these changes as is. 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
