kou commented on code in PR #334:
URL: https://github.com/apache/arrow-go/pull/334#discussion_r2011546095
##########
.github/workflows/test.yml:
##########
@@ -214,7 +214,7 @@ jobs:
run: brew install apache-arrow
- name: Setup PKG_CONFIG_PATH
run: |
- echo "PKG_CONFIG_PATH=$(brew --prefix
openssl@3)/lib/pkgconfig:$PKG_CONFIG_PATH" >> $GITHUB_ENV
+ echo "PKG_CONFIG_PATH=$(brew --prefix
openssl@3)/lib/pkgconfig:$(brew --prefix
apache-arrow)/lib/pkgconfig:$PKG_CONFIG_PATH" >> $GITHUB_ENV
Review Comment:
If we depend on only libraries installed by Homebrew, `$(brew --prefix)` is
better.
If we depend on apache-arrow installed by Homebrew and libraries installed
by not Homebrew, `$(brew --prefix apache-arrow)` is better.
I think that our CI is the former.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
